跳到主内容
智客 ZICQ

技能库 智客分类:安全测试 pr-review

Pr Review

审查 PyTorch 调取代码质量、测试范围、安全性和后向兼容性的请求。 在审查PR时使用,在被要求审查代码更改时使用,或者当用户提到"审查PR","代码审查",或者"检查这个PR"时使用.

3073 安装量

官方网址:skills.sh

技能介绍

先看中文介绍;官方 description 原文单独保留,不改写 SKILL.md。

做什么

审查 PyTorch 调取代码质量、测试范围、安全性和后向兼容性的请求

何时用

审查 PR , 当被要求审查代码更改时, 或者当用户提到“ 审查 PR ” , “ 代码审查 ” , 或者“ 检查此 PR ”

代理如何加载

按 Agent Skills 渐进披露:启动时只加载 name 与 description(约 100 token);任务匹配后才读入整份 SKILL.md 正文;scripts/、references/、assets/ 仅在需要时再读。 本文件正文结构:PyTorch PR Review Skill、Usage Modes、No Argument、Local CLI Mode、Get PR details、Get the diff。

文件分析

文件分析:这是一份仅含 SKILL.md 的指令型技能,代理激活后整份正文进入上下文。

官方 description(原文)

Review PyTorch pull requests for code quality, test coverage, security, and backward compatibility. Use when reviewing PRs, when asked to review code changes, or when the user mentions "review PR", "code review", or "check this PR".

PyTorch PR Review SkillUsage ModesNo ArgumentLocal CLI ModeGet PR detailsGet the diffGet PR commentsLocal Branch ModeGet current branch nameGet list of changed files compared to mainGet full diff compared to mainGet commit log for the branch

来源分类:skills.sh agent-skill

SKILL.md 与 Agent 调用

官方规范 ↗
name
pr-review
description
Review PyTorch pull requests for code quality, test coverage, security, and backward compatibility. Use when reviewing PRs, when asked to review code changes, or when the user mentions "review PR", "code review", or "check this PR".
  1. 发现技能客户端向 Agent 提供名称与描述目录。
  2. 匹配与调用用户指定或任务匹配后,载入 SKILL.md 指令。
  3. 按需加载按步骤读取参考文档、使用脚本与素材。

具体调用语法与可用工具以目标 Agent 客户端为准。 查看调用机制说明 ↗

安装这个技能

Skills CLI ↗

先选择目标 Agent 和安装范围,保留技能包的附属文件,安装后检查客户端能否发现该技能。

交给 Agent 安装

复制安装指令给支持 Agent Skills 的代理,确认其中的目标目录与客户端匹配。

把 Agent Skill「pr-review」安装到我的项目:SKILL.md 原文与官方 description 见 https://zicq.com/zh/skills/skl-eff911af5c8c2a04-%E5%AE%A1%E9%98%85.html
请存为 .cursor/skills/pr-review/SKILL.md 或 .claude/skills/pr-review/SKILL.md,frontmatter 的 name 与 description 保持原样,不要改写。

GitHub 完整包 ↗

终端安装 · Skills CLI

需要 Node.js 与 npx。先查看仓库技能列表,确认实际名称。

npx skills add 'https://github.com/pytorch/pytorch' --list

npx skills add 'https://github.com/pytorch/pytorch' --skill 'pr-review'

CLI 会交互选择目标 Agent,默认安装到项目;用户级安装使用 -g。先通过查看命令核对仓库内容,再用 npx skills list 检查已安装技能。

阅读排版
--- name: pr-review description: Review PyTorch pull requests for code quality, test coverage, security, and backward compatibility. Use when reviewing PRs, when asked to review code changes, or when the user mentions "review PR", "code review", or "check this PR". --- # PyTorch PR Review Skill Review PyTorch pull requests focusing on what CI cannot check: code quality, test coverage adequacy, security vulnerabilities, and backward compatibility. ## Usage Modes ### No Argument If the user invokes `/pr-review` with no arguments, **do not perform a review**. Instead, ask the user what they would like to review: > What would you like me to review? > - A PR number or URL (e.g., `/pr-review 12345`) > - A local branch (e.g., `/pr-review branch`) ### Local CLI Mode The user provides a PR number or URL: ``` /pr-review 12345 /pr-review https://github.com/pytorch/pytorch/pull/12345 ``` For a detailed review with line-by-line specific comments: ``` /pr-review 12345 detailed ``` Use `gh` CLI to fetch PR data: ```bash # Get PR details gh pr view --json title,body,author,baseRefName,headRefName,files,additions,deletions,commits # Get the diff gh pr diff # Get PR comments gh pr view --json comments,reviews ``` ### Local Branch Mode Review changes in the current branch that are not in `main`: ``` /pr-review branch /pr-review branch detailed ``` Use git commands to get branch changes: ```bash # Get current branch name git branch --show-current # Get list of changed files compared to main git diff --name-only main...HEAD # Get full diff compared to main git diff main...HEAD # Get commit log for the branch git log main..HEAD --oneline # Get diff stats (files changed, insertions, deletions) git diff --stat main...HEAD ``` For local branch reviews: - The "Summary" should describe what the branch changes accomplish based on commit messages and diff - Use the current branch name in the review header instead of a PR number - All other review criteria apply the same as PR reviews ### GitHub Actions Mode When invoked via `@claude /pr-review` on a GitHub PR, the action pre-fetches PR metadata and injects it into the prompt. Detect this mode by the presence of ``, ``, and `` tags in the prompt. The prompt already contains: - PR metadata (title, author, branch names, additions/deletions, file count) - PR body/description - All comments and review comments (with file/line references) - List of changed files with paths and change types Use git commands to get the diff and commit history. The base branch name is in the prompt context (look for `PR Branch: -> ` or the `baseBranch` field). ```bash # Get the full diff against the base branch git diff origin/...HEAD # Get diff stats git diff --stat origin/...HEAD # Get commit history for this PR git log origin/..HEAD --oneline # If the base branch ref is not available, fetch it first git fetch origin --depth=1 ``` Do NOT use `gh` CLI commands in this mode -- only git commands are available. All PR metadata, comments, and reviews are already in the prompt context; only the diff and commit log need to be fetched via git. ## Review Philosophy A single line of code can have deep cross-cutting implications: a missing device guard causes silent data corruption on multi-GPU, a missing `Composite` dispatch key breaks every out-of-tree backend, a manual dtype check instead of `TensorIterator` silently skips type promotion. **Treat every line as potentially load-bearing.** 1. **Only report problems** — The review output must contain only issues, concerns, and actionable suggestions. Do NOT mention things that are done correctly, do NOT praise good decisions, do NOT explain why something is fine. If a section has no problems, omit it entirely. The reader's time is precious — every sentence must point to something that needs fixing or further discussion. 2. **Investigate, don't guess** — When uncertain whether a checklist item applies, spawn a sub-agent to read the relevant code. A reviewer who guesses wrong provides negative value. 3. **Review the design, not just the implementation** — A PR can have perfectly correct implementation of a bad design. Question side-channel communication, on/off private flags, and demand concrete interface documentation for new contracts between components. 4. **Focus on what CI cannot check** — Don't comment on formatting, linting, type errors, or CI failures. Focus on design quality, interface correctness, thread safety, BC implications, test adequacy, and pattern adherence. 5. **Everything is a must-fix** — There are no "nits." If it's worth mentioning, it's worth fixing. Every inconsistency degrades the codebase over time. 6. **Be specific and actionable** — Reference file paths and line numbers. Name the function/class/file the author should use. 7. **Match the immediate context** — Read how similar features are already implemented in the same file. Pattern mismatches within a file are always wrong. 8. **Assume competence** — The author knows PyTorch; explain only non-obvious context. 9. **No repetition** — Each observation appears in exactly one section of the review output. ### Using sub-agents The review checklist is large. You cannot hold the full context of every infrastructure system in your head. **Spawn sub-agents** to investigate whether checklist items apply: read surrounding code, infrastructure the PR should be using, or tests that should exist. Spawn them in parallel for independent areas. A typical medium PR should spawn 3-8 sub-agents. Sub-agents overlap on purpose. Expect the same defect back from two or three of them in different words; that signals importance, not multiplicity. Reconcile in Step 4, before spending verification agents on it. ## Review Workflow ### Step 1: Understand Context Before reviewing, build understanding of what the PR touches and why: 1. Identify the purpose of the change from title/description/issue 2. Group changes by type (new code, tests, config, docs) 3. Note the scope of changes (files affected, lines changed) 4. Spawn sub-agents to read the unchanged code surrounding each significantly changed file to understand existing patterns and infrastructure ### Step 2: Deep Review Go through **every changed line** in the diff and evaluate it against the review checklist in [review-checklist.md](review-checklist.md). ### Step 3: Check Backward Compatibility Evaluate BC implications per [bc-guidelines.md](bc-guidelines.md). For non-trivial BC questions, spawn a sub-agent to search for existing callers of the modified API. ### Step 4: Consolidate Findings Deduplicate **before** you draft, and before Step 5 as it would slow it down significantly. Flatten every candidate — yours and every sub-agent's — into a list of `(file:line, one-line claim)` pairs, then collapse it: - **Same root cause → one finding.** Two sub-agents describing one defect from different angles is the expected outcome of fanning out over adjacent areas, not corroboration of two defects. - **Same fix → one finding.** If a single edit resolves several bullets, that is one finding with several consequences. - **Same `file:line` twice → merge**, unless you can name two independent defects. Only then assign each survivor to exactly one section (see "One finding, one section" under Output Format) and write it up. Every finding must be traceable to a specific line in the diff. ### Step 5: Fact-Check Fact-check the **consolidated** list — one sub-agent per surviving finding, never one per raw candidate. Spawn the agents in parallel. Each independently verifies the claim by re-reading the relevant code and surrounding context, and returns **valid**, **invalid**, or **needs rewording**. Drop invalid issues, reword the rest. If unsure, leave the issue with a comment for the author that this is low confidence. ## Output Format Structure your review as follows. **Omit sections where you have no problems to report** — most reviews should only have a few sections. Do not write "No concerns", "Looks good", or any affirmative commentary. Every sentence in the review must identify a problem or request a change. The Summary section is the one exception: it should briefly state what the PR does (1 sentence) and then state the problems found, or explicitly say no issues were found. ```markdown ## PR Review: # ## Branch Review: (vs main) ### Summary What the PR does (1 sentence), then the overall verdict. ### Code Quality [Problems only] ### Infrastructure [Problems only — flag checklist items that are violated] ### Testing [Problems only — missing tests, wrong patterns, inadequate coverage] ### API Design [Problems only] ### Security [Problems only] ### Thread Safety [Problems only] ### Backward Compatibility [Problems only] ### Performance [Problems only] ### Recommendation **Approve** / **Request Changes** / **Needs Discussion** Missing tests (new functionality without tests, bug fixes without regression tests) always means **Request Changes**. [Brief justification — focus on what blocks approval, if anything] ``` **One finding, one section.** The categories overlap by construction — a missing test for a bad public API is legitimately API Design, Testing, and Code Quality. Assign each finding to exactly one section, first match wins: 1. **Security** — has a security consequence 2. **Thread Safety** — has a concurrency consequence 3. **Backward Compatibility** — breaks or risks breaking existing callers 4. **API Design** — the defect is in a public or frozen interface (names, signatures, documented semantics) 5. **Infrastructure** — a missing or incorrect hook into an existing PyTorch subsystem 6. **Testing** — the defect is *only* absent or inadequate coverage 7. **Performance** 8. **Code Quality** — everything else State the finding's full consequence once, in its assigned section. When it genuinely spans categories, say so inline in that one bullet ("this is also a BC break for out-of-tree backends") rather than adding a second bullet under the other section. This precedence governs the eight finding sections only. Summary and Recommendation are not finding buckets — see their rules in the template above. Neither is Specific Comments — see its rules below. Do not invent sections outside this template. File a finding by its *consequence*, not its file type: a docstring that misstates operator semantics is API Design, not documentation. Where [review-checklist.md](review-checklist.md) groups or names a topic differently — e.g. it nests API Design under Code Quality, calls its infrastructure section "PyTorch Infrastructure", and has no Backward Compatibility section at all (that lives in [bc-guidelines.md](bc-guidelines.md)) — that organizes the checklist, not the output; this precedence wins. ### Specific Comments (Detailed Review Only) **Only include this section if the user requests a "detailed" or "in depth" review.** **Do not repeat observations already made in other sections.** This section is for points too localized to carry their own categorized finding — single-line naming, wording, or stale-comment notes. Anything with a behavioral or interface consequence belongs in one of the eight sections above. When requested, add file-specific feedback with line references: ```markdown ### Specific Comments - `torch/example/module.py:78` - reuses the name of the enclosing loop variable - `aten/src/ATen/native/Example.cpp:203` - the `TORCH_CHECK` message says "tensor", but the parameter is a list - `torch/example/lowering.py:512` - stale comment: describes the pre-refactor control flow ``` ## Files to Reference When reviewing, consult these project files for context — read them rather than relying on memory, as they change frequently: - `CLAUDE.md` - Coding style philosophy and testing patterns - `CONTRIBUTING.md` - PR requirements and review process - `torch/testing/_internal/common_utils.py` - Test patterns and utilities - `torch/testing/_internal/opinfo/core.py` - OpInfo test framework - `aten/src/ATen/native/native_functions.yaml` - Operator declarations (for checking tags, dispatch keys, structured kernels) - `tools/autograd/derivatives.yaml` - Backward formulas (for checking if an op should register here) - `aten/src/ATen/native/tags.yaml` - Operator semantic tags

相关技能

安全测试

Skill Vetter

人工智能特工的安全第一技能审查。 在安装来自 ClawdHub, GitHub 或其他来源的任何技能之前使用 。 检查红旗,许可范围,可疑图案.

安全测试

Moltguard

MoltGuard——由OpenGuardrails担任OpenClaw保安. 安装 MoltGuard 以保护你和你的人类免受迅速注射、数据过滤和恶意命令的影响。 资料来源:https://github.com/openguardrails/openguardrails/tre…

安全测试

Security Auditor

用于审查安全漏洞代码,实施认证流,审计OWASP Top 10,配置CORS/CSP头,处理秘密,输入验证,SQL注射预防,XSS保护,或任何与安全相关的代码审查.

安全测试

Skill Vetter

安装任何AI代理技能前的安全审查协议. 红旗侦取入证盗取,疏通密码,放出. 风险分类:低/中/高/高。 编制结构化审查报告。 不先运行此功能, 绝不安装不信任的技能 .